From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Thu, 11 Feb 2021 19:27:24 GMT
Subject: Re: [PATCH 12/12] test-lib-functions: split out {debug,path,text} helpers
Message-ID: <20210211192724.GF1015009@szeder.dev>
In-Reply-To: <xmqqpn18yee4.fsf@gitster.c.googlers.com>

On Tue, Feb 09, 2021 at 04:06:59PM -0800, Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
> 
> > Split out the debug, path and text miscellaneous helpers into their
> > own files. The "test -[efsd]" etc. helpers were not all in one place
> > in test-lib-functions.sh, I think moving them into their own file
> > makes it easier to follow the code.
> 
> I'd prefer not to see this done.  It would be fine to move them in
> different sections but still in the same file to group related
> helpers together, but I am having enough trouble when deciding to
> look into which between test-lib.sh and test-lib-functions.sh in the
> current organization already.  And it will make the situation even
> worse if we did this, no?

Indeed, I'd rather not see this one, either.