From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Fri, 13 Nov 2020 23:43:19 GMT
Subject: Re: [PATCH] t5310-pack-bitmaps: skip JGit tests with SHA256
Message-ID: <20201113234319.GM6252@camp.crustytoothpaste.net>
In-Reply-To: <20201113215307.20855-1-szeder.dev@gmail.com>

On 2020-11-13 at 21:53:07, SZEDER Gábor wrote:
> In 't5310-pack-bitmaps.sh' two tests make sure that our pack bitmaps
> are compatible with JGit's bitmaps.  Alas, not even the most recent
> JGit version (5.9.0.202009080501-r) supports SHA256 yet, so when this
> test script is run with GIT_TEST_DEFAULT_HASH=sha256 on a setup with
> JGit installed in PATH, then these two tests fail.
> 
> Protect these two tests with the SHA1 prereq in order to skip them
> when testing with SHA256.

Yeah, this seems like a reasonable thing to do.
-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US