From: Felipe Contreras Date: Wed, 28 Oct 2020 02:07:09 GMT Subject: [PATCH v3 26/29] completion: bash: trivial cleanup Message-ID: <20201028020712.442623-27-felipe.contreras@gmail.com> In-Reply-To: <20201028020712.442623-1-felipe.contreras@gmail.com> There's no need to set a variable we are not going to use. Signed-off-by: Felipe Contreras --- contrib/completion/git-completion.bash | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 26d6ee20b0..ed059f35c3 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -416,14 +416,13 @@ __gitcomp_builtin () local options eval "options=\${$var-}" - local completion_helper - if [ "$GIT_COMPLETION_SHOW_ALL" = "1" ]; then - completion_helper="--git-completion-helper-all" - else - completion_helper="--git-completion-helper" - fi - if [ -z "$options" ]; then + local completion_helper + if [ "$GIT_COMPLETION_SHOW_ALL" = "1" ]; then + completion_helper="--git-completion-helper-all" + else + completion_helper="--git-completion-helper" + fi # leading and trailing spaces are significant to make # option removal work correctly. options=" $incl $(__git ${cmd/_/ } $completion_helper) " || return -- 2.29.1