From: Jeff King <peff@peff.net>
Date: Tue, 27 Oct 2020 07:24:45 GMT
Subject: Re: [PATCH 4/3] am, sequencer: stop parsing our own committer ident
Message-ID: <20201027072445.GF3005508@coredump.intra.peff.net>
In-Reply-To: <xmqqft60gbci.fsf@gitster.c.googlers.com>

On Mon, Oct 26, 2020 at 10:12:45AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > By the way, I wondered why we needed to do this parsing at all. The
> > patch below does this in a much simpler way. It's a little bit ugly, I
> > think, because we have to call getenv() ourselves. But that's the way
> > fmt_ident() has always worked. We could probably improve that now that
> > it takes a whose_ident flag (before that, it had no idea if we wanted
> > author or committer ident).
> >
> > This is on top of the fixes (but we'd perhaps just want to do those on
> > 'maint' as the minimal fix).
> 
> This could be the nicest step in the whole series, but let's leave
> it out of the branch meant for 'maint'.

I think that's sensible. Looks like you queued it separately already, so
thank you. :)

-Peff