From: Taylor Blau <me@ttaylorr.com>
Date: Tue, 20 Oct 2020 20:15:35 GMT
Subject: Re: [PATCH v4] t7201: put each command on a separate line
Message-ID: <20201020201535.GB75186@nand.local>
In-Reply-To: <xmqqa6wgbqpq.fsf@gitster.c.googlers.com>

On Tue, Oct 20, 2020 at 01:13:53PM -0700, Junio C Hamano wrote:
> Charvi Mendiratta <charvi077@gmail.com> writes:
>
> > Modern practice is to avoid multiple commands per line,
> > and instead place each command on its own line.
> >
> > Signed-off-by: Charvi Mendiratta <charvi077@gmail.com>
> > ---
>
> This looks good, but I am wondering what happened between v3 and
> v4.

When I applied this locally, I used this patch as a replacement for the
last patch of v3 [1]. That kept everything passing after each patch.

> As you've demonstrated through the microproject that you can now
> comfortably be involved in the review discussion, I am tempted to
> suggest that we declare victory at this point and move on, but I
> don't know what the plans are for the other 4 patches (I guess we
> won't miss them that much---the micros are meant to be practice
> targets).

Yup, ditto.

> Thanks.

Thanks,
Taylor

[1]: https://lore.kernel.org/git/20201020114319.18245-6-charvi077@gmail.com/