From: Michał Kępień <michal@isc.org>
Date: Tue, 13 Oct 2020 06:37:22 GMT
Subject: Re: [PATCH v2 2/3] diff: add -I<regex> that ignores matching changes
Message-ID: <20201013063722.GC3278@larwa.hq.kempniu.pl>
In-Reply-To: <xmqqpn5nm87u.fsf@gitster.c.googlers.com>

> > the use of `xcalloc()`, and now that I think further about it, an
> > `xmalloc()` should be plenty enough: `regcomp()` does not need that struct
> > to be initialized to all zero.
> 
> Yup, I think it makes sense.

Sure thing, I will switch to xmalloc() in v3.  xcalloc()'s semantics
("allocate one structure of this size") appealed to me, but there is
indeed no need to zero-initialize the allocated memory before passing it
to regcomp().

-- 
Best regards,
Michał Kępień