From: Jonathan Tan Date: Thu, 08 Oct 2020 01:48:55 GMT Subject: Re: [PATCH v2 05/13] reftable: utility functions Message-ID: <20201008014855.1416580-1-jonathantanmy@google.com> In-Reply-To: <4190da597e65bce072fa3c37c9410a56def4b489.1601568663.git.gitgitgadget@gmail.com> > From: Han-Wen Nienhuys > > This commit provides basic utility classes for the reftable library. > > Since the reftable library must compile standalone, there may be some overlap > with git-core utility functions. > > Signed-off-by: Han-Wen Nienhuys > --- > Makefile | 26 ++++++- > reftable/basics.c | 131 +++++++++++++++++++++++++++++++++ > reftable/basics.h | 48 +++++++++++++ > reftable/blocksource.c | 148 ++++++++++++++++++++++++++++++++++++++ > reftable/blocksource.h | 22 ++++++ > reftable/compat.c | 110 ++++++++++++++++++++++++++++ > reftable/compat.h | 48 +++++++++++++ > reftable/publicbasics.c | 100 ++++++++++++++++++++++++++ > reftable/reftable-tests.h | 22 ++++++ > reftable/strbuf.c | 142 ++++++++++++++++++++++++++++++++++++ > reftable/strbuf.h | 80 +++++++++++++++++++++ > reftable/strbuf_test.c | 37 ++++++++++ > reftable/system.h | 51 +++++++++++++ > t/helper/test-reftable.c | 8 +++ > t/helper/test-tool.c | 1 + > t/helper/test-tool.h | 1 + I think duplicating things like strbuf is an unnecessary burden if Git is to maintain this library. Something like "reftable will only import git-compat-util.h and strbuf.h, and any project that wants to use reftable must make sure that these functions and data structures are available" would be more plausible.