From: Jonathan Tan Date: Thu, 08 Oct 2020 01:45:12 GMT Subject: Re: [PATCH v2 04/13] reftable: add a barebones unittest framework Message-ID: <20201008014512.1413826-1-jonathantanmy@google.com> In-Reply-To: > From: Han-Wen Nienhuys > > Signed-off-by: Han-Wen Nienhuys > --- > reftable/test_framework.c | 68 +++++++++++++++++++++++++++++++++++++++ > reftable/test_framework.h | 59 +++++++++++++++++++++++++++++++++ Even if reftable will be a project maintained by the Git project but independent enough to be used by other projects, I don't think it's worth creating a separate test framework. E.g. as far as I can tell, when we import sha1dc, we don't import any tests, so I don't think they need to import tests either - they can run the tests in the Git repo themselves if they need to.