From: Pratyush Yadav Date: Tue, 22 Sep 2020 09:52:41 GMT Subject: Re: [PATCH v2] style(git-gui): Fix mixed tabs & spaces; Prefer tabs. Message-ID: <20200922095241.oswiczosfepj6ngx@yadavpratyush.com> In-Reply-To: <20200909130136.39098-1-serg.partizan@gmail.com> On 09/09/20 04:01PM, Serg Tereshchenko wrote: > Hi Pratyush, > > Thanks for suggestion about scissors, i was wondering how to do this > properly, i'll try it next time. > > > I'm not on board with this entire hunk. In many C projects (like Linux, > > Git, etc) the "switch" and the "case" are on the same indent level. I > > can see instances of this in almost every switch-case block in > > git-gui.sh as well. We should stick to the local convention here and > > drop this hunk. > > > > I can make these changes locally and merge them so no need to re-roll... > > unless you have any counter points that is. > > I have no objections, please drop that hunk. Merged with the above changes. Thanks. > -- > Regards, > Serg Tereshchenko -- Regards, Pratyush Yadav