From: Jeff King <peff@peff.net>
Date: Fri, 18 Sep 2020 17:21:33 GMT
Subject: Re: [PATCH 2/2] Allow passing pipes for input pipes to diff --no-index
Message-ID: <20200918172133.GC183026@coredump.intra.peff.net>
In-Reply-To: <20200918171950.GA183026@coredump.intra.peff.net>

On Fri, Sep 18, 2020 at 01:19:50PM -0400, Jeff King wrote:

> Getting back to the overall feature, this is definitely something that
> has come up before. The last I know of is:
> 
>   https://lore.kernel.org/git/20181220002610.43832-1-sandals@crustytoothpaste.net/
> 
> which everybody seemed to like the direction of; I suspect the original
> author (cc'd) just never got around to it again. Compared to this
> approach, it uses a command-line option to avoid dereferencing symlinks.
> That puts an extra burden on the caller to pass the option, but it's way
> less magical; you could drop all of the "does this look like a symlink
> to a pipe" heuristics. It would also be much easier to test. ;)

Of course I forgot to add the cc. +cc brian.