From: Jeff King <peff@peff.net>
Date: Wed, 16 Sep 2020 18:43:59 GMT
Subject: Re: [PATCH 09/15] remote-mediawiki tests: use "$dir/" instead of "$dir."
Message-ID: <20200916184359.GC33925@coredump.intra.peff.net>
In-Reply-To: <20200916102918.29805-10-avarab@gmail.com>

On Wed, Sep 16, 2020 at 12:29:12PM +0200, Ævar Arnfjörð Bjarmason wrote:

> Change UI messages to use "$dir/" instead of "$dir.". I think this is
> less confusing.

Yeah, a trailing slash is a nice indicator. In the first message,
though:

> -		echo "$MW_FILENAME downloaded in $(pwd). "\
> +		echo "$MW_FILENAME downloaded in $(pwd)/ "\
>  			"You can delete it later if you want."

...we've lost the period separating the two sentences. So you get:

  foo downloaded in /some/path/  You can delete it later if you want.

(the two spaces are because "echo" adds an extra space between the
arguments). Maybe:

  foo downloaded in /some/path/; you can delete it later if you want.

or something?

-Peff