From: Jeff King <peff@peff.net>
Date: Wed, 16 Sep 2020 16:36:17 GMT
Subject: Re: [PATCH 1/4] clone: add tests for --template and some disallowed option pairs
Message-ID: <20200916163617.GC17726@coredump.intra.peff.net>
In-Reply-To: <20200915160943.1253867-1-sean@barag.org>

On Tue, Sep 15, 2020 at 09:09:44AM -0700, Sean Barag wrote:

> On Fri, 11 Sep 2020 15:56:22 -0400, Jeff King wrote:
>  > do we really care about code 128, or just failure? test_must_fail
>    might be a better choice
> 
> Good point - `test_must_fail` is probably fine here.  I went with an
> explicit error code so this test wouldn't pass in the event of an
> outright crash, but I'm happy to adjust for v2.

That's good thinking, but test_must_fail already has you covered; it
will complain about any death-by-signal. It wouldn't distinguish
between, say exit codes 128 and 1, but 128 is the code used by our die()
function, so expecting it isn't very specific anyway. :)

-Peff