From: Jeff King <peff@peff.net>
Date: Thu, 10 Sep 2020 19:29:20 GMT
Subject: Re: [PATCH v2 4/7] quote_path: code clarification
Message-ID: <20200910192920.GA1920978@coredump.intra.peff.net>
In-Reply-To: <xmqqblidpj9x.fsf@gitster.c.googlers.com>

On Thu, Sep 10, 2020 at 11:40:42AM -0700, Junio C Hamano wrote:

> >> +	int force_dq = ((flags & QUOTE_PATH_QUOTE_SP) && strchr(rel, ' '));
> >> [...]
> >> +	quote_c_style_counted(rel, strlen(rel), out, NULL, !!force_dq);
> >
> > I think force_dq is already normalized to 0/1 by the &&, so we wouldn't
> > need the "!!" here.
> 
> True.  CQUOTE_NODQ patch would get rid of it in the end, though ;-)

Oh, true. I didn't think to look ahead. Having done so, yeah, I don't
see any point in quibbling about this one. :)

-Peff