From: Shourya Shukla <shouryashukla.oo@gmail.com>
Date: Fri, 21 Aug 2020 05:22:35 GMT
Subject: Re: [PATCH v3 4/4] submodule: port submodule subcommand 'summary' from shell to C
Message-ID: <20200821052235.GA84497@konoha>
In-Reply-To: <20200818020838.GA1872632@coredump.intra.peff.net>

> The "missing_src" and "missing_dst" parameters in this function are
> unused.

Yes, they are unused.

> I _think_ they can be safely removed, and are not a sign of a bug. We
> seem to fully handle them in the calling function. But this is the first
> time I looked at the code, and I didn't dig too deeply.

Sure. They an be removed. I am sending a patch for the same.