From: Jeff King <peff@peff.net>
Date: Wed, 19 Aug 2020 13:51:09 GMT
Subject: Re: [PATCH v2 0/2] Clean up some memory leaks in and around dir.c
Message-ID: <20200819135109.GA2498279@coredump.intra.peff.net>
In-Reply-To: <pull.831.v2.git.git.1597791506.gitgitgadget@gmail.com>

On Tue, Aug 18, 2020 at 10:58:24PM +0000, Elijah Newren via GitGitGadget wrote:

> Some memory leaks in dir.c were making it hard for me to find my own leaks
> in merge-ort. I followed a few threads and tried to both clean up the leaks
> and make the API less prone to incorrect use.
> 
> Changes since v1:
> 
>  * dropped the first patch, since Peff submitted an identical patch a day
>    before me
>  * implemented Peff's suggestions to rename dir_free() to dir_clear() and
>    have it call dir_init() at the end so that folks can re-use the struct
>    after dir_clear() if they so choose.

Thanks, both patches look good to me.

-Peff