From: Jeff King <peff@peff.net>
Date: Tue, 18 Aug 2020 02:08:38 GMT
Subject: Re: [PATCH v3 4/4] submodule: port submodule subcommand 'summary' from shell to C
Message-ID: <20200818020838.GA1872632@coredump.intra.peff.net>
In-Reply-To: <20200812194404.17028-5-shouryashukla.oo@gmail.com>

On Thu, Aug 13, 2020 at 01:14:04AM +0530, Shourya Shukla wrote:

> +static void print_submodule_summary(struct summary_cb *info, char* errmsg,
> +				    int total_commits, const char *displaypath,
> +				    const char *src_abbrev, const char *dst_abbrev,
> +				    int missing_src, int missing_dst,
> +				    struct module_cb *p)

The "missing_src" and "missing_dst" parameters in this function are
unused.

I _think_ they can be safely removed, and are not a sign of a bug. We
seem to fully handle them in the calling function. But this is the first
time I looked at the code, and I didn't dig too deeply.

-Peff