From: Emily Shaffer <emilyshaffer@google.com>
Date: Mon, 17 Aug 2020 12:16:43 GMT
Subject: Re: [PATCH 3/5] make git-bugreport a builtin
Message-ID: <20200817121643.GB44309@google.com>
In-Reply-To: <20200813145936.GC891370@coredump.intra.peff.net>

On Thu, Aug 13, 2020 at 10:59:36AM -0400, Jeff King wrote:
> 
> There's no reason that bugreport has to be a separate binary. And since
> it links against libgit.a, it has a rather large disk footprint. Let's
> make it a builtin, which reduces the size of a stripped installation
> from 24MB to 22MB.
> 
> This also simplifies our Makefile a bit. And we can take advantage of
> builtin niceties like RUN_SETUP_GENTLY.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
>  Makefile                            |  6 +-----
>  builtin.h                           |  1 +
>  bugreport.c => builtin/bugreport.c  | 10 +++-------
>  contrib/buildsystems/CMakeLists.txt |  5 +----
>  git.c                               |  1 +
>  5 files changed, 7 insertions(+), 16 deletions(-)
>  rename bugreport.c => builtin/bugreport.c (96%)

And I saw no surprises in the diff. As stated in
https://lore.kernel.org/git/20200817121239.GA44309@google.com I think
this is a fine idea, so:

Reviewed-by: Emily Shaffer <emilyshaffer@google.com>