From: Jeff King Date: Thu, 13 Aug 2020 15:08:28 GMT Subject: Re: [PATCH 1/5] Makefile: drop builtins from MSVC pdb list Message-ID: <20200813150828.GA891963@coredump.intra.peff.net> In-Reply-To: <20200813150428.GA2244@syl.lan> On Thu, Aug 13, 2020 at 11:04:28AM -0400, Taylor Blau wrote: > On Thu, Aug 13, 2020 at 10:57:19AM -0400, Jeff King wrote: > > Over the years some more programs have become builtins, but nobody > > updated this MSVC-specific section of the file (which specifically says > > that it should not include builtins). Let's bring it up to date. > > > > Signed-off-by: Jeff King > > --- > > Given that nobody has mentioned this, it makes me wonder if anybody is > > even using this part of the Makefile at all these days. Or maybe having > > extra lines here isn't a problem (though it's also missing some entries, > > like one for git-bugreport). > > If having extra entries didn't cause a problem, I would suspect that it > was just that. But that missing entries *also* doesn't cause a problem, > I'd suspect that this section of the Makefile just isn't being used. > > Of course, I'm not using it since I'm not on Windows, but maybe dscho or > Stolee would know if there are legitimate uses. Of course, if there > aren't, I'm favor of getting rid of this section entirely. I cc'd Jeff Hostetler, who added it. :) I'm also pretty not-knowledgeable about Windows, but I think that anybody using MSVC would do so through Visual Studio these days. And that's being covered with recent cmake stuff. Or maybe I'm just clueless. We'll see. -Peff