From: Shourya Shukla Date: Wed, 12 Aug 2020 19:27:37 GMT Subject: [PATCH v2 4/4] t7401: add a NEEDSWORK Message-ID: <20200812192737.13971-5-shouryashukla.oo@gmail.com> In-Reply-To: <20200812192737.13971-1-shouryashukla.oo@gmail.com> Add a NEEDSWORK regarding the outdated syntax and working of the test, which may need to be improved to obtain better and desired results. While at it, change the word 'test' to 'test script' in the test description to avoid ambiguity. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Helped-by: Taylor Blau Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index dd0e88fc6a..8f5e4515d3 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -5,8 +5,11 @@ test_description='Summary support for submodules -This test tries to verify the sanity of summary subcommand of git submodule. +This test script tries to verify the sanity of summary subcommand of git submodule. ' +# NEEDSWORK: This test script is old fashioned and may need a big cleanup since +# there are lots of commands taking place outside of 'test_expect_success' +# block, which is no longer in good-style. . ./test-lib.sh -- 2.28.0