From: Jeff King <peff@peff.net>
Date: Tue, 04 Aug 2020 21:26:51 GMT
Subject: Re: [PATCH v2 0/7] making log --first-parent imply -m
Message-ID: <20200804212651.GC2020725@coredump.intra.peff.net>
In-Reply-To: <87wo2eyuo0.fsf@osv.gnss.ru>

On Wed, Aug 05, 2020 at 12:21:03AM +0300, Sergey Organov wrote:

> Here is the patch reduced to absolute minimum, both functionally and
> textually. I removed even 'all', as it has its own subtleties that need
> further discussion, so the patch only introduces --diff-merges=off.

Yeah, I agree this is the minimum (though I suspect the documentation
may be easier with "all" or similar to explain "-m" in terms of
--diff-merges).

> If it looks OK, I'll do documentation and tests parts.

My nits about the die() message remain, but other than that it looks OK
to me.

-Peff