From: Jeff King <peff@peff.net>
Date: Fri, 31 Jul 2020 18:02:35 GMT
Subject: Re: [PATCH] commit-graph: add verify changed paths option
Message-ID: <20200731180235.GA846620@coredump.intra.peff.net>
In-Reply-To: <pull.687.git.1596181765336.gitgitgadget@gmail.com>

On Fri, Jul 31, 2020 at 07:49:25AM +0000, Son Luong Ngoc via GitGitGadget wrote:

> From: Son Luong Ngoc <sluongng@gmail.com>
> 
> Add '--has-changed-paths' option to 'git commit-graph verify' subcommand
> to validate whether the commit-graph was written with '--changed-paths'
> option.

Is a single boolean flag sufficient? If you have incrementals, you might
have some slices with this chunk and some without. What should the
boolean be in that case?

I thought we had some way of reporting the number of commits covered by
filters, but I can't seem to find it.

Our "test-tool read-graph" can report on whether there's a bloom filter
chunk, but I think it also doesn't distinguish between different slices
(and anyway, it wouldn't be suitable for tools that don't rely on an
actual built git.git directory).

-Peff