From: Shourya Shukla <shouryashukla.oo@gmail.com>
Date: Sat, 25 Jul 2020 17:31:18 GMT
Subject: Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
Message-ID: <20200725173118.GA614724@konoha>
In-Reply-To: <20200717105406.82226-3-mirucam@gmail.com>

> Following 'enum bisect_error' vocabulary, return variable 'res' is
> always non-positive.
> Let's use '-res' instead of 'abs(res)' to make the code clearer.

> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> Helped-by: Junio C Hamano <gitster@pobox.com>

Although there is no set rule for this, but I think that your sign-off
goes at the last generally. This is what I have seen on various patches.