From: Shourya Shukla <shouryashukla.oo@gmail.com>
Date: Sat, 25 Jul 2020 17:27:56 GMT
Subject: Re: [PATCH v5 01/13] bisect--helper: BUG() in cmd_*() on invalid subcommand
Message-ID: <20200725172756.GA614052@konoha>
In-Reply-To: <20200717105406.82226-2-mirucam@gmail.com>

Hello Miriam,

> In cmd_bisect__helper() function, there would be a bug
> if an invalid or no subcommand was passed.return error()
> should be replaced by BUG() in that case.

> Mentored-by: Christian Couder <chriscool@tuxfamily.org>
> Mentored-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> ---

I think we can try for a better message. Maybe something like:

    One encounters a BUG when an invalid or no subcommand is passed to
    'cmd_bisect__helper()'. BUG() out instead of returning an error.

> -		return error("BUG: unknown subcommand '%d'", cmdmode);
> +		BUG("unknown subcommand %d", (int)cmdmode);

Do we need to typecast an integer to an integer here?

Regards,
Shourya Shukla