From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 09 Jul 2020 02:29:42 GMT
Subject: Re: [PATCH 09/21] maintenance: add commit-graph task
Message-ID: <20200709022942.39848-1-jonathantanmy@google.com>
In-Reply-To: <c8fbd14d41093e12905027ff628b98652cd931d0.1594131695.git.gitgitgadget@gmail.com>

> +static int run_write_commit_graph(struct repository *r)
> +{
> +	int result;
> +	struct argv_array cmd = ARGV_ARRAY_INIT;
> +
> +	argv_array_pushl(&cmd, "-C", r->worktree,
> +			 "commit-graph", "write",
> +			 "--split", "--reachable",
> +			 NULL);

As mentioned in my reply to an earlier patch (sent a few minutes ago),
this won't work if there are environment variables like GIT_DIR present.

Besides that, the overall design looks reasonable.