From: Jonathan Tan Date: Thu, 09 Jul 2020 02:25:19 GMT Subject: Re: [PATCH 08/21] maintenance: initialize task array and hashmap Message-ID: <20200709022519.38407-1-jonathantanmy@google.com> In-Reply-To: <5cdd38afa60cdf768dd194f90ae0b2190123fdea.1594131695.git.gitgitgadget@gmail.com> > This list is also inserted into a hashmap. This allows command-line > arguments to quickly find the tasks by name, not sensitive to case. To > ensure this list and hashmap work well together, the list only contains > pointers to the struct information. This will allow a sort on the list > while preserving the hashmap data. I think having the hashmap is unnecessarily complicated in this case - with the small number of tasks, a list would be fine. But I don't feel strongly about this.