From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 01 Jun 2020 20:00:01 GMT
Subject: Re: [PATCH 8/8] upload-pack: send part of packfile response as uri
Message-ID: <20200601200001.GB98003@google.com>
In-Reply-To: <2cfee363873736d9ff73cd38d96f3533bb49c904.1590789428.git.jonathantanmy@google.com>

Jonathan Tan wrote:

> +++ b/builtin/pack-objects.c
[...]
> @@ -192,6 +227,11 @@ static void create_pack_file(const struct object_array *have_obj,
>  					 spec);
>  		}
>  	}
> +	if (uri_protocols) {
> +		for (i = 0; i < uri_protocols->nr; i++)
> +			argv_array_pushf(&pack_objects.args, "--uri-protocol=%s",
> +					 uri_protocols->items[0].string);

Should this be items[i]?

Thanks,
Jonathan