From: Jeff King <peff@peff.net>
Date: Wed, 27 May 2020 18:08:25 GMT
Subject: Re: [PATCH 04/12] upload-pack: move filter_capability_requested to upload_pack_data
Message-ID: <20200527180825.GC4020820@coredump.intra.peff.net>
In-Reply-To: <20200527164742.23067-5-chriscool@tuxfamily.org>

On Wed, May 27, 2020 at 06:47:34PM +0200, Christian Couder wrote:

> As we cleanup 'upload-pack.c' by using 'struct upload_pack_data'
> more thoroughly, let's move the filter_capability_requested
> static variable into this struct.
> 
> It is only used by protocol v0 code since protocol v2 assumes
> certain baseline capabilities, but rolling it into
> upload_pack_data and just letting v2 code ignore it as it does
> now is more coherent and cleaner.

Looks good, though this is another candidate for grouping/commenting in
the struct that it's v0-only.

-Peff