From: Denton Liu <liu.denton@gmail.com>
Date: Thu, 21 May 2020 11:25:45 GMT
Subject: Re: [PATCH v2 3/4] lib-submodule-update: prepend "git" to $command
Message-ID: <20200521112545.GB581643@generichostname>
In-Reply-To: <1746f977-64cc-ede0-04f7-7cfd1afb1691@iee.email>

Hi Philip,

On Thu, May 21, 2020 at 11:39:48AM +0100, Philip Oakley wrote:
> > diff --git a/t/lib-submodule-update.sh b/t/lib-submodule-update.sh
> > index bb36287803..fb6c0f3d4f 100755
> > --- a/t/lib-submodule-update.sh
> > +++ b/t/lib-submodule-update.sh
> > @@ -307,8 +307,8 @@ test_submodule_content () {
> >  # to protect the history!
> >  #
> >  
> > -# Internal function; use test_submodule_switch() or
> > -# test_submodule_forced_switch() instead.
> > +# Internal function; use test_submodule_switch_func(), test_submodule_switch_func(),
> Is this an accidental duplication of  test_submodule_switch_func(),?
> (spotted in passing)

Thanks, good catch. The second one should be test_submodule_switch().

> --
> Philip