From: Jeff King <peff@peff.net>
Date: Fri, 15 May 2020 18:38:38 GMT
Subject: Re: [PATCH 11/13] upload-pack: remove static variable 'stateless_rpc'
Message-ID: <20200515183838.GK3692649@coredump.intra.peff.net>
In-Reply-To: <20200515100454.14486-12-chriscool@tuxfamily.org>

On Fri, May 15, 2020 at 12:04:52PM +0200, Christian Couder wrote:

> As we cleanup 'upload-pack.c' by using 'struct upload_pack_data'
> more thoroughly, let's remove the 'stateless_rpc' static
> variable, as we can now use the field of 'struct upload_pack_data'
> with the same name instead.

OK, here's where all of the struct passing in the previous commits
begins to pay off, as we get to start deleting globals:

>  static int use_sideband;
> -static int stateless_rpc;
>  static const char *pack_objects_hook;

Definitely a positive direction, and it should be obvious that all of
the appropriate spots have been converted because the old variable goes
away.

-Peff