From: Jeff King <peff@peff.net>
Date: Fri, 15 May 2020 18:03:16 GMT
Subject: Re: [PATCH 01/13] upload-pack: remove unused 'wants' from upload_pack_data
Message-ID: <20200515180316.GA3692649@coredump.intra.peff.net>
In-Reply-To: <20200515100454.14486-2-chriscool@tuxfamily.org>

On Fri, May 15, 2020 at 12:04:42PM +0200, Christian Couder wrote:

> As we cleanup 'upload-pack.c' by using 'struct upload_pack_data'
> more thoroughly, let's remove 'struct object_array wants' from
> 'struct upload_pack_data', as it appears to be unused.

Yep, the diff shows this is clearly not used.

I was a bit curious how it came to be unused, but it was like this from
the very start of that struct being added in 3145ea957d (upload-pack:
introduce fetch server command, 2018-03-15). We don't need it because of
the local want_obj in upload_pack_v2(), but I see you deal with that in
the next commit. Looks good so far.

-Peff