From: Jeff King <peff@peff.net>
Date: Thu, 14 May 2020 18:12:26 GMT
Subject: Re: [PATCH v3 0/8] commit-graph: drop CHECK_OIDS, peel in callers
Message-ID: <20200514181226.GD2430834@coredump.intra.peff.net>
In-Reply-To: <cover.1589407014.git.me@ttaylorr.com>

On Wed, May 13, 2020 at 03:59:25PM -0600, Taylor Blau wrote:

> Here is a tiny reroll to my series to drop the commit-graph's behavior
> of complaining about non-commit OIDs on input with '--stdin-commits'. I
> promised this reroll after Peff's review beginning in [1].
> 
> Not a great deal has changed, but I mostly took every suggestion that
> Peff put forward (in the sub-thread beginning at [1]). The "big deals"
> since last time are:

Thanks. With the exception of the decl-after-statement (and the tiny
if() nit which we could take or leave), this looks good to me.

The fix for the decl-after-statement should be easy, but you might want
to double check your build setup ("make DEVELOPER=1" does complain about
it, and I think that means our CI should, too; if it doesn't, we should
fix that).

-Peff