From: Jonathan Nieder Date: Mon, 11 May 2020 23:26:29 GMT Subject: Re: [PATCH v5] bugreport: collect list of populated hooks Message-ID: <20200511232629.GB141481@google.com> In-Reply-To: <20200511221430.174122-1-emilyshaffer@google.com> Hi, Emily Shaffer wrote: > Occasionally a failure a user is seeing may be related to a specific > hook which is being run, perhaps without the user realizing. While the > contents of hooks can be sensitive - containing user data or process > information specific to the user's organization - simply knowing that a > hook is being run at a certain stage can help us to understand whether > something is going wrong. > > Without a definitive list of hook names within the code, we compile our > own list from the documentation. This is likely prone to bitrot, but > designing a single source of truth for acceptable hooks is too much > overhead for this small change to the bugreport tool. > > Signed-off-by: Emily Shaffer > --- > Documentation/git-bugreport.txt | 1 + > bugreport.c | 52 +++++++++++++++++++++++++++++++++ > t/t0091-bugreport.sh | 15 ++++++++++ > 3 files changed, 68 insertions(+) Reviewed-by: Jonathan Nieder Thanks.