From: Son Luong Ngoc <sluongng@gmail.com>
Date: Sun, 10 May 2020 15:52:28 GMT
Subject: Re: [PATCH v3 2/3] multi-pack-index: respect repack.packKeptObjects=false
Message-ID: <20200510155228.GB27407@C02YX140LVDN>
In-Reply-To: <20200510063844.GA14311@danh.dev>

Hi,

Thanks Danh and Junio for the testing improvement suggestions.
I think these are the points I will adopt into next version:

- Remove the 3rd patch and keep the removal of dollar sign locally
  inside `repack respects repack.packKeptObjects=false`.

- Change `head -n -3 | tail -n -1` to `sed -n 3p`

- Apply test_line_count on keep-list for failing fast (before touch)

Cheers,
Son Luong.