From: Taylor Blau Date: Thu, 07 May 2020 17:22:01 GMT Subject: Re: [PATCH 2/2] auto-gc: pass --quiet down from am, commit, merge and rebase Message-ID: <20200507172201.GD26677@syl.local> In-Reply-To: <20200506201830.92818-3-gitster@pobox.com> Hi Junio, On Wed, May 06, 2020 at 01:18:30PM -0700, Junio C Hamano wrote: > These commands take the --quiet option for their own operation, but > they forget to pass the option down when they invoke "git gc --auto" > internally. > > Teach them to do so using the run_auto_gc() helper we added in the > previous step. > > Signed-off-by: Junio C Hamano > --- > builtin/am.c | 3 +-- > builtin/commit.c | 3 +-- > builtin/merge.c | 3 +-- > builtin/rebase.c | 3 +-- > 4 files changed, 4 insertions(+), 8 deletions(-) Very nicely done. Sorry that these took me a little while to look at. This and the patch before it both have my: Reviewed-by: Taylor Blau Thanks, Taylor