From: Carlo Marcelo Arenas Belón Date: Wed, 06 May 2020 21:47:23 GMT Subject: [PATCH v2 1/4] credential: update description for credential_from_url_gently Message-ID: <20200506214726.81854-2-carenas@gmail.com> In-Reply-To: <20200506214726.81854-1-carenas@gmail.com> c44088ecc4 (credential: treat URL without scheme as invalid, 2020-04-18) changes the implementation for this function to return -1 if protocol is missing. Update blurb to match implementation. Reviewed-by: Jeff King Signed-off-by: Carlo Marcelo Arenas Belón --- credential.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/credential.h b/credential.h index d99ec42b2a..f51703d9ce 100644 --- a/credential.h +++ b/credential.h @@ -177,8 +177,8 @@ void credential_write(const struct credential *, FILE *); * Parse a url into a credential struct, replacing any existing contents. * * If the url can't be parsed (e.g., a missing "proto://" component), the - * resulting credential will be empty but we'll still return success from the - * "gently" form. + * resulting credential will be empty and the function will return an + * error (even in the "gently" form). * * If we encounter a component which cannot be represented as a credential * value (e.g., because it contains a newline), the "gently" form will return -- 2.26.2.686.gfaf46a9ccd