From: Jeff King <peff@peff.net>
Date: Wed, 06 May 2020 16:21:53 GMT
Subject: Re: [PATCH 3/4] credential: update gitcredentials documentation
Message-ID: <20200506162153.GA1841928@coredump.intra.peff.net>
In-Reply-To: <20200505013908.4596-4-carenas@gmail.com>

On Mon, May 04, 2020 at 06:39:07PM -0700, Carlo Marcelo Arenas Belón wrote:

> Clarify the expected effect of all attributes and how the helpers
> are expected to handle them and the context where they operate.
> 
> While at it, space the descriptions for clarity, and add a paragraph
> mentioning the early termination in the list processing of helpers,
> to complement the one about the special "quit" attribute.

Yep, these all make sense. One nit:

> +While it is possible to override all attributes, well behaving helpers
> +should refrain to do so for any attributes other than username and
> +password.

"refrain from doing so" would be more idiomatic English.

-Peff