From: Jeff King <peff@peff.net>
Date: Sun, 03 May 2020 06:58:26 GMT
Subject: Re: [RFC PATCH] credential: minor documentation fixes
Message-ID: <20200503065826.GB1829906@coredump.intra.peff.net>
In-Reply-To: <20200503063423.83152-1-carenas@gmail.com>

On Sat, May 02, 2020 at 11:34:23PM -0700, Carlo Marcelo Arenas Belón wrote:

> c44088ecc4 (credential: treat URL without scheme as invalid, 2020-04-18)
> changes the implementation for creential_from_url_gently to retun -1 if
> protocol is missing, but didn't update this blurb.

Yeah, this makes sense. s/creential/credential/.

> the order of parameters used in credential_match was inconsistent
> between credential.c and credential.h as well, so update both to
> match the current implementation.

Yes, looks like this has been wrong since the beginning in 118250728e
(credential: apply helper config, 2011-12-10). I checked the callers to
make sure none of them had gotten it backwards, but they all look right
(and just the declaration is wrong).

-Peff