From: Taylor Blau <me@ttaylorr.com>
Date: Thu, 30 Apr 2020 20:20:14 GMT
Subject: Re: Seg Fault on git fetch with fetch.negotiationAlgorithm=skipping
Message-ID: <20200430202014.GB2014@syl.local>
In-Reply-To: <450D5CC7-113A-40D8-9CD4-53786198526D@gmail.com>

Hi Son,

On Thu, Apr 30, 2020 at 04:55:07PM +0200, Son Luong Ngoc wrote:
> Hi folks,
>
> We recently encountered a segfault during a git fetch
> strace output could be found https://gist.github.com/sluongng/e48327cc911c617ed2ef8578acc2ea34
>
> The root cause was due to having `fetch.negotiationAlgorithm=skipping`
> The repo is about linux.git size with a few NULL commit that we have been using `fsck.skipList`
> on both server and client side to skip.

Are you able to share a core file? If not, it would be very helpful for
you to 'git fast-export --anonymize ...' and see if you can reproduce
the problem on an anonymized copy of your repository.

I can speculate about the cause of the crash from your strace above, but
a core file would be more helpful.

> Is this and edge case for the new algorithm?
>
> Cheers,
> Son Luong.

Thanks,
Taylor