From: Carlo Marcelo Arenas Belón Date: Tue, 28 Apr 2020 16:42:04 GMT Subject: Re: [PATCH v4 2/4] git-credential-store: skip empty lines and comments from store Message-ID: <20200428164204.GA56126@Carlos-MBP> In-Reply-To: On Tue, Apr 28, 2020 at 12:09:50PM -0400, Eric Sunshine wrote: > On Tue, Apr 28, 2020 at 6:53 AM Carlo Marcelo Arenas Belón > wrote: > > git-credential-store: skip empty lines and comments from store > > I don't see anything in this patch which makes it skip anything at > all; it only introduces a new test. my bad, forgot to fix the subject when rerolling; does something like: credential-store: show "regression" when bogus credentials in file make sense for the reroll? Carlo