From: Jeff King Date: Mon, 27 Apr 2020 20:12:28 GMT Subject: Re: [PATCH 0/8] CMake build system for git Message-ID: <20200427201228.GD1728884@coredump.intra.peff.net> In-Reply-To: <20200427200852.GC1728884@coredump.intra.peff.net> On Mon, Apr 27, 2020 at 04:08:52PM -0400, Jeff King wrote: > Skimming the patches, I do wish I didn't see so much repetition with the > existing Makefile. I know that some of the logic will just have to be > ported manually, but surely we could be pulling things like the list of > libgit_SOURCES from the Makefile as the single source of truth? Thinking I surely couldn't be the only one to think of this, I dug further into some of the sub-threads. And indeed, it seems like you are on the same page here. IMHO it is worth making the cmake file depend as much as possible on what's in the Makefile. -Peff