From: Miriam Rubio Date: Thu, 23 Apr 2020 07:06:53 GMT Subject: [PATCH v3 01/12] bisect--helper: fix `cmd_*()` function switch default return Message-ID: <20200423070704.39872-2-mirucam@gmail.com> In-Reply-To: <20200423070704.39872-1-mirucam@gmail.com> In a `cmd_*()` function, return `error()` cannot be used because that translates to `-1` and `cmd_*()` functions need to return exit codes. Let's fix switch default return. Mentored-by: Christian Couder Mentored-by: Johannes Schindelin Signed-off-by: Miriam Rubio --- builtin/bisect--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index c1c40b516d..a81a2c76ff 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -711,7 +711,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) res = bisect_start(&terms, no_checkout, argv, argc); break; default: - return error("BUG: unknown subcommand '%d'", cmdmode); + BUG("unknown subcommand %d", (int)cmdmode); } free_terms(&terms); -- 2.25.0