From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 22 Apr 2020 16:41:50 GMT
Subject: Re: [PATCH] config.mak.uname: Define FREAD_READS_DIRECTORIES for GNU/Hurd
Message-ID: <20200422164150.GA140314@google.com>
In-Reply-To: <20200422153347.40018-1-jrtc27@jrtc27.com>

Jessica Clarke wrote:

> GNU/Hurd is another platform that behaves like this. Set it to
> UnfortunatelyYes so that config directory files are correctly processed.
> This fixes the corresponding 'proper error on directory "files"' test in
> t1308-config-set.sh.
>
> Thanks-to: Jeff King <peff@peff.net>
> Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.

> diff --git a/config.mak.uname b/config.mak.uname
> index 0ab8e00938..3e526f6b9f 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -308,6 +308,7 @@ ifeq ($(uname_S),GNU)
>  	NO_STRLCPY = YesPlease
>  	HAVE_PATHS_H = YesPlease
>  	LIBC_CONTAINS_LIBINTL = YesPlease
> +	FREAD_READS_DIRECTORIES = UnfortunatelyYes
>  endif

I wonder why we set up this knob this way.  A lot of operating systems
support fopen(..., "r") of a directory --- wouldn't it make sense for
FREAD_READS_DIRECTORIES to be the default and for users on stricter
platforms to be able to set FREAD_DOES_NOT_READ_DIRECTORIES if they
want to speed Git up by taking advantage of their saner fread?

Thanks,
Jonathan