From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 02 Apr 2020 23:01:53 GMT
Subject: Re: [PATCH v2 1/2] promisor-remote: accept 0 as oid_nr in function
Message-ID: <20200402230153.45407-1-jonathantanmy@google.com>
In-Reply-To: <xmqqblo93c31.fsf@gitster.c.googlers.com>

> > + * If oid_nr is 0, this function returns 0 (success) immediately.
> 
> Is this worth saying?  If you ask to lazily grab 0 objects, it is
> probably clear that no object would be read before the helper
> returns.
> 
> When oid_nr==0 you are allowed to pass oids==NULL, but otherwise,
> oids==NULL would be an error.  Is that the kind of difference you
> wanted to point out, I wonder?

Thanks for taking a look. Yes that was the difference I wanted to point
out. After some thought, maybe I'll replace it with "oids points to an
array of OIDs of size oid_nr. If oid_nr is 0, oids can be anything.".