From: Jeff King <peff@peff.net>
Date: Fri, 20 Mar 2020 05:32:14 GMT
Subject: Re: [PATCH 3/6] t5003: skip conversion test if unzip -a is unavailable
Message-ID: <20200320053214.GD499858@coredump.intra.peff.net>
In-Reply-To: <20200320003921.GB1858@danh.dev>

On Fri, Mar 20, 2020 at 07:39:21AM +0700, Danh Doan wrote:

> > > +test_lazy_prereq UNZIP_CONVERT '
> > > +	(
> > > +		mkdir unzip-convert &&
> > > +		cd unzip-convert &&
> > > +		"$GIT_UNZIP" -a "$TEST_DIRECTORY"/t5003/infozip-symlinks.zip
> > > +	)
> > > +'
> > 
> > Lazy prereqs are already evaluated in a throw-away directory, so you can
> > drop the subshell and mkdir/cd.
> 
> I was trying to keep it consistent with UNZIP_SYMLINKS above it.
> Maybe, it's worth to clean it, too.

Ah, sorry, I should have looked at more context. I think it would be
worth cleaning up the existing one.

-Peff