From: Danh Doan <congdanhqx@gmail.com>
Date: Fri, 20 Mar 2020 00:39:21 GMT
Subject: Re: [PATCH 3/6] t5003: skip conversion test if unzip -a is unavailable
Message-ID: <20200320003921.GB1858@danh.dev>
In-Reply-To: <20200319160310.GD3513282@coredump.intra.peff.net>

On 2020-03-19 12:03:10-0400, Jeff King <peff@peff.net> wrote:
> On Thu, Mar 19, 2020 at 09:00:04PM +0700, Đoàn Trần Công Danh wrote:
> 
> > Alpine Linux's default unzip(1) doesn't support `-a`.
> > 
> > Skip those tests on that platform.
> 
> Makes sense. One minor nit:
> 
> > +test_lazy_prereq UNZIP_CONVERT '
> > +	(
> > +		mkdir unzip-convert &&
> > +		cd unzip-convert &&
> > +		"$GIT_UNZIP" -a "$TEST_DIRECTORY"/t5003/infozip-symlinks.zip
> > +	)
> > +'
> 
> Lazy prereqs are already evaluated in a throw-away directory, so you can
> drop the subshell and mkdir/cd.

I was trying to keep it consistent with UNZIP_SYMLINKS above it.
Maybe, it's worth to clean it, too.

-- 
Danh