From: Pratyush Yadav Date: Thu, 19 Mar 2020 16:05:51 GMT Subject: Re: [PATCH v2 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5 Message-ID: <20200319160551.ivivebvecw2totnf@yadavpratyush.com> In-Reply-To: On 19/03/20 11:22AM, Eric Sunshine wrote: > On Tue, Mar 17, 2020 at 9:29 AM Pratyush Yadav wrote: > > Some MacOS distributions ship with Tcl 8.5. This means we can't use > > TclOO. So, use our homegrown class.tcl instead. > > > > Changes in v2: > > - Add a note _after_ checking if the user agreed to the deletion. > > Otherwise, if the user denies, two "zombie" notes are left lying > > around which will never be activated. This means that the chord won't > > complete and the index won't be unlocked, leading to git-gui becoming > > frozen. > > Thanks. I did some light testing on Mac OS. This re-roll seems to > address the reported problems[1] and allows the new "delete unstaged > file" feature to work on older Tcl. As a fix for the Git 2.25 > regression which resulted in git-gui being unable to launch on Mac OS, > this path series seems "good to go". Thanks for testing. Merged. Thanks all. > [1]: https://github.com/prati0100/git-gui/issues/26 -- Regards, Pratyush Yadav