From: Jeff King <peff@peff.net>
Date: Thu, 19 Mar 2020 16:03:10 GMT
Subject: Re: [PATCH 3/6] t5003: skip conversion test if unzip -a is unavailable
Message-ID: <20200319160310.GD3513282@coredump.intra.peff.net>
In-Reply-To: <27c7813c0fe81455b675611b9e11fee6ee2a79e9.1584625896.git.congdanhqx@gmail.com>

On Thu, Mar 19, 2020 at 09:00:04PM +0700, Đoàn Trần Công Danh wrote:

> Alpine Linux's default unzip(1) doesn't support `-a`.
> 
> Skip those tests on that platform.

Makes sense. One minor nit:

> +test_lazy_prereq UNZIP_CONVERT '
> +	(
> +		mkdir unzip-convert &&
> +		cd unzip-convert &&
> +		"$GIT_UNZIP" -a "$TEST_DIRECTORY"/t5003/infozip-symlinks.zip
> +	)
> +'

Lazy prereqs are already evaluated in a throw-away directory, so you can
drop the subshell and mkdir/cd.

-Peff