From: Jonathan Tan Date: Tue, 10 Mar 2020 21:29:02 GMT Subject: Re: [PATCH v2 3/7] index-pack: remove redundant parameter Message-ID: <20200310212902.77827-1-jonathantanmy@google.com> In-Reply-To: <20200228000412.GC12115@google.com> > It looks like compare_ofs_delta_bases() could be similarly cleaned up > here? This seems to be the only caller. [snip] > And same with compare_ref_delta_bases here. That's true, although I didn't need these cleanups for the rest of my patches, so I think it's better to defer them to reduce the overall size of the patch.