From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Tue, 25 Feb 2020 00:19:24 GMT
Subject: Re: [PATCH 02/10] pack-objects: read delta base oid into object_id struct
Message-ID: <20200225001924.GJ6462@camp.crustytoothpaste.net>
In-Reply-To: <20200224042944.GB1018190@coredump.intra.peff.net>

On 2020-02-24 at 04:29:44, Jeff King wrote:
> @@ -1707,9 +1702,13 @@ static void check_object(struct object_entry *entry)
>  			unuse_pack(&w_curs);
>  			return;
>  		case OBJ_REF_DELTA:
> -			if (reuse_delta && !entry->preferred_base)
> -				base_ref = use_pack(p, &w_curs,
> -						entry->in_pack_offset + used, NULL);
> +			if (reuse_delta && !entry->preferred_base) {
> +				oidread(&base_ref,
> +					use_pack(p, &w_curs,
> +						 entry->in_pack_offset + used,
> +						 NULL));
> +				have_base = 1;
> +			}

Thanks for using oidread here.  That makes my nascent future series that
adds an algorithm member to struct object_id much easier.
-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204