From: Emily Shaffer <emilyshaffer@google.com>
Date: Mon, 24 Feb 2020 23:46:54 GMT
Subject: Re: [PATCH v4 3/3] tag: use new advice API to check visibility
Message-ID: <20200224234654.GC255447@google.com>
In-Reply-To: <3cc0a17123dc2575deacb62f762a35fef5f2c185.1582557199.git.gitgitgadget@gmail.com>

On Mon, Feb 24, 2020 at 03:13:18PM +0000, Heba Waly via GitGitGadget wrote:
> From: Heba Waly <heba.waly@gmail.com>
> 
> Following the new helpers added to the advice library,
> replace the global variable check approach by the new
> API calls
> 
> Signed-off-by: Heba Waly <heba.waly@gmail.com>
> ---
>  advice.c       | 2 --
>  advice.h       | 1 -
>  builtin/tag.c  | 5 +++--
>  t/t7004-tag.sh | 1 +
>  4 files changed, 4 insertions(+), 5 deletions(-)

More deleted lines than added lines always makes me a little happier ;)

Reviewed-by: Emily Shaffer <emilyshaffer@google.com>